[Webkit-unassigned] [Bug 46624] Web Inspector: implement pausing on event listeners (back-end part)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46624


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69343|review?                     |
               Flag|                            |




--- Comment #12 from Pavel Feldman <pfeldman at chromium.org>  2010-10-01 06:41:19 PST ---
(From update of attachment 69343)
View in context: https://bugs.webkit.org/attachment.cgi?id=69343&action=review

>> WebCore/inspector/InspectorInstrumentation.cpp:162
>> +    inspectorController->instrumentWillDispatchEvent(event);
> 
> see comments about this method in InspectorController

Could you rename this method so that it would better reflect the nature of the call?

> WebCore/inspector/InspectorInstrumentation.cpp:180
> +    TimelineAgentsStack& stack = timelineAgentsStack();

Extract method please. Also this is very, very complex. Could we return Page* from all *::will methods and call ::did with it?

> WebCore/inspector/InspectorInstrumentation.cpp:184
> +        stack.removeLast();

You should check depth before this call. Also, please add assertions here with depth expectations.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.