[Webkit-unassigned] [Bug 46259] [Qt] QNetworkReplyHandler forces buffered output for FormData with files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46259


Andreas Kling <andreas.kling at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69445|review?                     |review-
               Flag|                            |




--- Comment #7 from Andreas Kling <andreas.kling at nokia.com>  2010-10-01 04:50:35 PST ---
(From update of attachment 69445)
View in context: https://bugs.webkit.org/attachment.cgi?id=69445&action=review

Close, but not quite there yet.

> WebCore/platform/network/qt/QNetworkReplyHandler.cpp:88
> +        if (element.m_type == FormDataElement::data) 
> +            m_dataSize += element.m_data.size();
> +        else {
> +            QFileInfo fi(element.m_filename);
> +            m_fileSize += fi.size();
> +        }

If building with ENABLE(BLOB), this fails to take FormDataElement::encodedBlob into account. (see FormData.h)

> WebCore/platform/network/qt/QNetworkReplyHandler.cpp:92
> +#ifdef QT_NETWORK_DEBUG
> +    qDebug() << __PRETTY_FUNCTION__ << "FileSize=" << m_fileSize << "DataSize=" << m_dataSize;
> +#endif

Please remove this.
This kind of output should only be added for things that are non-trivial to do using a debugger.

> WebCore/platform/network/qt/QNetworkReplyHandler.h:100
> +    qint64 getFormDataSize() const { return m_totalSize; }

You don't need the m_totalSize member, just "return m_dataSize + m_fileSize;"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.