[Webkit-unassigned] [Bug 46051] SVG: Make RenderPath DRT output platform-independent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46051


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68073|review?                     |review-
               Flag|                            |




--- Comment #15 from Nikolas Zimmermann <zimmermann at kde.org>  2010-10-01 03:10:10 PST ---
(From update of attachment 68073)
As discussed on IRC, the right way to go is to introduce a RenderSVGShape class whose repaintRectInLocalCoordinates can be dumped.
The problem is that dumping RenderPath::repaintRectInLocalCoordinates, is that it's platform-dependant, as Path::boundingBox is used.

As first step, I'd introduce RenderSVGShape : public RenderPath (which should be renamed and moved to rendering/svg/RenderSVGPath first)
and let SVGCircle/RectElement etc. create RenderSVGShape instead of RenderSVGPath.

Once that's done, we need to introduce platform-dependant ways to create rects, circles, instead of the home-brewn code in Path.cpp (addEllipse, etc.)
Then we need to write a method which calculates the circle/rect/etc. boundaries in a _cross platform_ fashion.

Then RenderSVGShape can use this new logic, and inherit from RenderSVGModelObject, and be completly decoupled from RenderSVGPath.
Once that's done the DRT problem vanishes.

(This is just a short summary of the IRC discussion).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.