[Webkit-unassigned] [Bug 46937] [chromium] Minor naming cleanup in WebDragData

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46937





--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2010-10-01 01:13:06 PST ---
(From update of attachment 69430)
View in context: https://bugs.webkit.org/attachment.cgi?id=69430&action=review

> WebKit/chromium/ChangeLog:10
> +        This is a two-part patch--one to add the new methods with normalized
> +        names, and a followup patch to remove the original methods once
> +        Chromium is updated.

You probably want to mention why we're doing this cleanup.

> WebKit/chromium/ChangeLog:19
> +        (WebKit::WebDragData::containsFilenames):
> +        (WebKit::WebDragData::filenames):
> +        (WebKit::WebDragData::setFilenames):
> +        (WebKit::WebDragData::appendToFilenames):
> +        (WebKit::WebDragData::fileContentFilename):
> +        (WebKit::WebDragData::setFileContentFilename):

Could you mention which function replaces what?

> WebKit/chromium/src/WebDragData.cpp:163
> +    ensureMutable();
> +    Vector<String> filenamesCopy;
> +    filenamesCopy.append(filenames.data(), filenames.size());
> +    m_private->setFilenames(filenamesCopy);

Instead of duplicating code, can we call setFileNames here?  We can move the code here when we're removing setFileNames.

> WebKit/chromium/src/WebDragData.cpp:171
> +    ensureMutable();
> +    Vector<String> filenames = m_private->filenames();
> +    filenames.append(filename);
> +    m_private->setFilenames(filenames);

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.