[Webkit-unassigned] [Bug 35080] fast/css/font-face-opentype.html crashing on GTK bots
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 1 00:55:41 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=35080
--- Comment #3 from Martin Robinson <mrobinson at webkit.org> 2010-10-01 00:55:41 PST ---
(In reply to comment #2)
> The issue was that there is no m_pattern for custom fonts in FontPlatformData. This caused a crash when accessing m_pattern in FontCache::getFontDataForCharacters. The GTK fix is to make this check:
> // FIXME: This should not happen, apparently. We are null-checking
> // for now just to avoid crashing.
> if (!prim || !prim->m_pattern)
> return 0;
>
> The real fix would be generating m_patter from a FreeType font using http://fontconfig.org/fontconfig-devel/fcfreetypequeryface.html
Having the pattern only makes sense if FontConfig can return a proper list of fallbacks for custom fonts. My guess is that this is not the case with most custom fonts (or any?). I have reworked this method to deal with custom fonts here: https://bugs.webkit.org/show_bug.cgi?id=42052
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list