[Webkit-unassigned] [Bug 25770] [chromium] Crash in FontFallbackList::determinePitch(const Font* font)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 30 22:24:31 PST 2010


--- Comment #6 from David Levin <levin at chromium.org>  2010-11-30 22:24:31 PST ---
(In reply to comment #5)
> Do we need refactoring for this file so we can move all these static functions in this file at the beginning of this file?

Short answer: Sounds good.

Long answer:

I appreciate your goal of following the file's current style. However, here's a simple outlook that is slightly different:
1. WebKit has no stated style on this matter.
2. This file is solely used by Chromium (and thus almost always only modified by chromium folks).

Since there is no conflict between the two styles and Chromium has a standard practice here that makes readability easier for Chromium folks, I'd try to follow its standard. 

Feel free to submit a *different* patch that fixes places in this file where it doesn't meet this practice. (cc me and) I'm happy to r+ such a change.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list