[Webkit-unassigned] [Bug 48821] "elements" for form and fieldsset don't conform to the HTML5 spec

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 30 18:11:13 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=48821


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75205|review?                     |review-
               Flag|                            |




--- Comment #16 from Kent Tamura <tkent at chromium.org>  2010-11-30 18:11:13 PST ---
(From update of attachment 75205)
View in context: https://bugs.webkit.org/attachment.cgi?id=75205&action=review

> LayoutTests/fast/forms/script-tests/form-collection-elements-order.js:14
> +    if (owner.elements.length != victims.length)
> +      return 'length mismatch, elements.length = ' +
> +             owner.elements.length + ', expected length = ' + victims.length;
> +    for (var i = 0; i < victims.length; ++i)
> +      if (owner.elements[i] != victims[i])
> +        return 'element mismatch at index ' + i;
> +    return 'OK';

Indentation is inconsistent.

> WebCore/ChangeLog:6
> +        "elements" for form and fieldsset don't conform to the HTML5 spec
> +        https://bugs.webkit.org/show_bug.cgi?id=48821

We had better change the summary (and the bug title) because we address only <object>.

> WebCore/WebCore.xcodeproj/project.pbxproj:-21495
> -			developmentRegion = English;

Do not remove this line.  You need the latest Xcode.

> WebCore/html/FormAssociatedElement.cpp:2
> + * Copyright (c) 2010 Google Inc. All rights reserved.

This file contains a lot of code witten by non-Google. Please respect the original copyright header.

> WebCore/html/FormAssociatedElement.h:2
> + * Copyright (c) 2010 Google Inc. All rights reserved.

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list