[Webkit-unassigned] [Bug 50277] key member variable in NumericStrings CacheData is never initialized

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 30 17:15:55 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=50277





--- Comment #6 from Geoffrey Garen <ggaren at apple.com>  2010-11-30 17:15:55 PST ---
I think initializing key to 0 is misleading because it implies that 0 is a special sentry/invalid value, when it isn't. More work when initializing JSGlobalData is also not great, although it's not a huge concern, since creating JSGlobalData is relatively rare.

I'm not too excited about making cache misses slower just to make a tool happy. That said, if SunSpider and v8 don't complain about the change, it's probably OK.

Is there any way to fix this problem with valgrind-only annotations or code?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list