[Webkit-unassigned] [Bug 50277] key member variable in NumericStrings CacheData is never initialized

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50277





--- Comment #2 from Darin Adler <darin at apple.com>  2010-11-30 16:15:17 PST ---
(From update of attachment 75213)
View in context: https://bugs.webkit.org/attachment.cgi?id=75213&action=review

This patch doesn't fix a bug. There is no symptom. While the key has a random value in it, the value is guaranteed to have a null string, and the code always checks that.

I suspect this patch just makes a memory debugging tool stop complaining. Is there some other way to accomplish that without generating a lot of code that will run whenever we construct a JSGlobalData object?

> JavaScriptCore/runtime/NumericStrings.h:81
> +            CacheEntry()
> +            : key(0)
> +            {
> +            }

Initializing to zero is not all that helpful; zero itself has a cached string.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.