[Webkit-unassigned] [Bug 50263] Exception in flaky test reporting code in commit-queue

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50263





--- Comment #1 from Eric Seidel <eric at webkit.org>  2010-11-30 15:04:28 PST ---
This would happen any time the tests fail on the first run, but we fail to get results from that failure.

The code in question:

    def _test_patch(self):
        if self._patch.is_rollout():
            return True
        if self._test():
            return True

        first_failing_tests = self._failing_tests_from_last_run()
        if self._test():
            self._report_flaky_tests(first_failing_tests)
            return True

        second_failing_tests = self._failing_tests_from_last_run()
        if first_failing_tests != second_failing_tests:
            self._report_flaky_tests(first_failing_tests + second_failing_tests)
            return False

The fix is straightforward.  We just make "first_failing_tests != second_failing_tests" into "first_failing_tests and (first_failing_tests != second_failing_tests)".  However we might also want to add some special logging to track this case, as the layout tests shoudl not fail w/o us being able to get the results from the run!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.