[Webkit-unassigned] [Bug 49938] ApplyStyleCommand should take EditingStyle instead of CSSStyleDeclaration

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49938





--- Comment #3 from Tony Chang <tony at chromium.org>  2010-11-30 13:39:20 PST ---
(From update of attachment 74630)
View in context: https://bugs.webkit.org/attachment.cgi?id=74630&action=review

> WebCore/editing/ApplyStyleCommand.cpp:521
> +        // apply the block-centric properties of the style

Nit: Convert to a sentence (capitalize first letter and add a period) please.

> WebCore/editing/ApplyStyleCommand.cpp:525
> +        // apply any remaining styles to the inline elements

Nit: Convert to a sentence (capitalize first letter and add a period) please.

> WebCore/editing/Editor.cpp:858
> +            applyCommand(ApplyStyleCommand::create(m_frame->document(), EditingStyle::create(style).get(), editingAction));

If there's no refptr to hold the EditingStyle returned by ::create, will it get deleted properly?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.