[Webkit-unassigned] [Bug 50204] REGRESSION(r72861): editing/selection/click-left-of-rtl-wrapping-text.html and modify-up-on-rtl-wrapping-text.html fail on all but Mac platform

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 30 11:01:30 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=50204





--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2010-11-30 11:01:29 PST ---
(From update of attachment 75108)
View in context: https://bugs.webkit.org/attachment.cgi?id=75108&action=review

>> LayoutTests/editing/selection/click-left-of-rtl-wrapping-text.html:30
>> +    for (var i = 5; i == 5 || container.offsetHeight > heightOfLine * test.expected.length; i++)
> 
> I don't understand this for loop. i starts and 5 and checks for == 5 ?

This is a pseudo do-while.  I start at 5px and increase the width as long as the height is too big.  But the height is initially heightOfLine (which is shorter than heightOfLine * test.expected.length) so we need to this condition to set width to 5px first so that the height is larger than heightOfLine * test.expected.length.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list