[Webkit-unassigned] [Bug 48957] [Qt] Introduce QDRTNode for passing WebCore::Node across JS bridge

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48957





--- Comment #7 from Antonio Gomes <tonikitoo at webkit.org>  2010-11-30 09:38:16 PST ---
(From update of attachment 73173)
View in context: https://bugs.webkit.org/attachment.cgi?id=73173&action=review

> WebCore/bridge/qt/qt_runtime.cpp:142
> +    static QDRTNode create(Node* element)

'Node* element' looks strange to me, Robert. Could we just name it 'node'?

> WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:74
> +    WebCore::Node* m_element;

Ditto. m_node make more sense to me, and actually throughout the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.