[Webkit-unassigned] [Bug 50228] Theme not updated when MediaPlayer m_private engine changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50228





--- Comment #1 from Eric Carlson <eric.carlson at apple.com>  2010-11-30 07:42:48 PST ---
(In reply to comment #0)
> RenderTheme relies on the mediaElement supportsFullscreen and supportMuting to know wether 
> it should paint the fullscreen and mute buttons or not. The problem is that the MediaPlayer first 
> loads a NullMediaPlayerPrivate which doesn't support those. So if you display a page with a video
> element and controls enabled (no autoplay), the theme will be rendered without those buttons 
> until video playback starts and the controls are painted again.
> 
> So I think we could have a mediaPlayerBackendChanged() callback in the mediaPlayerClient 
> interface which in the case of the HTMLMediaElement trigger an update of the theme. Would 
> that make sense, Eric? The new callback would be called by the MediaPlayer each time 
> m_private variable is cleared/changed.

Sounds like a good idea.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.