[Webkit-unassigned] [Bug 50015] Move regex parsing and fallback handling to runtime/RegExp.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50015


Peter Varga <pvarga at inf.u-szeged.hu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74747|0                           |1
        is obsolete|                            |
  Attachment #74747|review?, commit-queue?      |
               Flag|                            |
  Attachment #75138|                            |review?, commit-queue?
               Flag|                            |




--- Comment #3 from Peter Varga <pvarga at inf.u-szeged.hu>  2010-11-30 06:44:23 PST ---
Created an attachment (id=75138)
 --> (https://bugs.webkit.org/attachment.cgi?id=75138&action=review)
proposed patch v2

Hi Gavin,

> What do you think of adding an enum to explicitly delineate the states?
Adding an enum instead of m_useInterpreter variable is sensible and it mades the code clearer.
I updated the patch.

> we should probably remove the compile method
I didn't remove the compile method. I think it makes the code seperatable and now it makes the logic of handling
RegExp states flexible.

> we should probably also remove the following comment from the header
I removed this comment. At first the solving of the FIXME looked pointless and I didn't modify it.

Your suggestion about the modification of RegExp::create needs more investigation because It needs changes
in those classes which implement the handling of regular expressions in runtime.

Regards,
Peter

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.