[Webkit-unassigned] [Bug 47311] Add layout tests for Entry.getMetadata (FileSystem API)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47311


Jian Li <jianli at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71481|review?                     |review-
               Flag|                            |




--- Comment #2 from Jian Li <jianli at chromium.org>  2010-11-29 21:28:39 PST ---
(From update of attachment 71481)
View in context: https://bugs.webkit.org/attachment.cgi?id=71481&action=review

> LayoutTests/fast/filesystem/resources/op-tests-helper.js:223
> +                var entryMetadataString = 'this.environment["' + symbol + '"]';

Might be better to make 'this.environment["' + symbol + '"]' a helper function in order to simplify the code.

> LayoutTests/fast/filesystem/resources/op-tests-helper.js:230
> +                this.errorCallback();

Probably we should continue to run next test even we fail the current test unless we encounter a severe error that cannot be recoverable,

> LayoutTests/fast/filesystem/resources/op-tests-helper.js:232
> +         };

'}' not aligned correctly.

> LayoutTests/fast/filesystem/resources/op-tests-helper.js:324
> +         };

ditto.

> LayoutTests/fast/filesystem/resources/op-tests-helper.js:331
> +            // Record rounded start date (current time minus 999 msec) here for the comparison. Entry.getMetadata() may return motd in seconds accuracy while new Date() is milliseconds accuracy.

What is motd?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.