[Webkit-unassigned] [Bug 45491] when empty, clicking "down" on outer-spin-button returns "max value"

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 29 18:56:25 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=45491





--- Comment #45 from Dai Mikurube <dmikurube at google.com>  2010-11-29 18:56:24 PST ---
(In reply to comment #43)
> (From update of attachment 75004 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75004&action=review
> 
> > WebCore/html/BaseDateAndTimeInputType.cpp:103
> > +double BaseDateAndTimeInputType::defaultValueForStepUp() const
> > +{
> > +    double ms = currentTimeMS();
> > +    double utcOffset = calculateUTCOffset();
> > +    double dstOffset = calculateDSTOffset(ms, utcOffset);
> > +    int offset = static_cast<int>((utcOffset + dstOffset) / msPerMinute);
> > +    return ms + (offset * msPerMinute);
> > +}
> 
> If the current date-time is 2010-11-30T23:00Z and the user's timezone is UTC+9, the default value would be
> date: 2010-12-01
> datetime: 2010-11-30T23:00Z
> datetime-local: 2010-12-01T08:00
> month: 2010-12
> time: 08:00
> week: 2010-Wxx (the week of 2010-12-01)
> 
> Right?
> 
> > WebCore/manual-tests/input-type-datetime-default-value.html:66
> > +<p>The input fields should show the current date/time (with + or - a unit date/time described below except for step=any).</p>
> 
> So, we should explain the expectations are current *local* date/time except type=datetime.

Thanks. Added some comments about local/UTC on source code and the description here.
Because not only local, I wrote local/UTC here. Added descriptions for each of types.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list