[Webkit-unassigned] [Bug 50186] Switch web audio code to use FloatPoint3D instead of Vector3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 29 16:15:21 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=50186





--- Comment #4 from Chris Rogers <crogers at google.com>  2010-11-29 16:15:21 PST ---
> Are these the last uses of Vector3? If so, I think we should remove those files as well. Or is that planned in a separate patch?

Yes, the new patch also removes wtf/Vector3.h



>> WebCore/platform/graphics/FloatPoint3D.h:178
>> +inline double distance(const FloatPoint3D& a, const FloatPoint3D& b)

> I'm not sure that adding this function to the global WebCore namespace is a good idea. Could it be expressed as a method "double distanceTo(const FloatPoint3D& other) const"?

Yes, I've changed this method to distanceTo() as you propose.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list