[Webkit-unassigned] [Bug 50038] Add word-prefix search options to the text search API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50038





--- Comment #10 from Andras Becsi <abecsi at webkit.org>  2010-11-29 14:49:43 PST ---
(From update of attachment 75040)
View in context: https://bugs.webkit.org/attachment.cgi?id=75040&action=review

Previously Qt had issues with clashing file names in WebCore and WebKit2, the build problem here seems to be caused by this, too. 
After renaming the WebCore/editing/FindOptions.h file to FindOptionFlag.h the Qt build had the following issues:

> WebCore/ChangeLog:49
> +        * platform/text/TextBoundaries.cpp:

This file is not listed in WebCore.pro and Qt seems to lack the isAlphanumeric function, too, which is used in this source.
Qt does not use ICU, AFAIK.

> WebCore/ChangeLog:52
> +        * platform/text/TextBoundaries.h:

Ditto.

> WebCore/editing/TextIterator.cpp:1941
> +size_t SearchBuffer::prependContext(const UChar* characters, size_t length)

This is inside a long #if USE(ICU_UNICODE) && !UCONFIG_NO_COLLATION guard which seems to be false on Qt thus the linking fails with undefined reference.

> WebCore/editing/TextIterator.cpp:2142
> -inline SearchBuffer::SearchBuffer(const String& target, bool isCaseSensitive)
> +inline SearchBuffer::SearchBuffer(const String& target, FindOptions options)
>      : m_target(isCaseSensitive ? target : target.foldCase())

A stray isCaseSensitive parameter was left here.

>> WebCore/page/Page.cpp:522
>> +        if (frame->editor()->findString(target, options & ~WrapAround | StartInSelection)) {
> 
> Some newer versions of gcc may warn about the mix of & and | without parentheses, correctly relying on operator precedence but confusing to some programmers. I suspect that could happening in the Qt build, or it’s possible it only applies to the && and || operators.

The rule also applies to bitwise operators.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.