[Webkit-unassigned] [Bug 48193] HTMLFormElement.elements doesn't include fieldsets

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48193





--- Comment #6 from Yael <yael.aharon at nokia.com>  2010-11-29 13:46:26 PST ---
(In reply to comment #3)
> (From update of attachment 75054 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75054&action=review
> 
> > WebCore/html/HTMLKeygenElement.h:39
> > -    virtual bool isEnumeratable() const { return false; }
> > +    virtual bool isEnumeratable() const { return true; }
> 
> You should instead just remove this member function entirely. The function inherited from HTMLSelectElement already returns true, there is no need to override.
> 
> > LayoutTests/fast/forms/script-tests/form-collection-elements.js:2
> > +debug("This test does not add object element as a listed element. Separate bug will be filed for that.");
> 
> I don’t think “separate bug will be filed” makes sense in a comment in the test. Maybe you mean we’ll test that with a separate test?
Thank you for the review. I will make the adjustments before committing. Since object elemnt is not as straightforward as keygen and fieldset, I filed https://bugs.webkit.org/show_bug.cgi?id=50179 to fix that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.