[Webkit-unassigned] [Bug 48193] HTMLFormElement.elements doesn't include fieldsets

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48193


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75054|review?                     |review+
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2010-11-29 13:40:55 PST ---
(From update of attachment 75054)
View in context: https://bugs.webkit.org/attachment.cgi?id=75054&action=review

> WebCore/html/HTMLKeygenElement.h:39
> -    virtual bool isEnumeratable() const { return false; }
> +    virtual bool isEnumeratable() const { return true; }

You should instead just remove this member function entirely. The function inherited from HTMLSelectElement already returns true, there is no need to override.

> LayoutTests/fast/forms/script-tests/form-collection-elements.js:2
> +debug("This test does not add object element as a listed element. Separate bug will be filed for that.");

I don’t think “separate bug will be filed” makes sense in a comment in the test. Maybe you mean we’ll test that with a separate test?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.