[Webkit-unassigned] [Bug 50172] Add remaining custom JSC web audio bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50172





--- Comment #3 from Chris Rogers <crogers at google.com>  2010-11-29 13:30:26 PST ---
(From update of attachment 75051)
View in context: https://bugs.webkit.org/attachment.cgi?id=75051&action=review

>> WebCore/bindings/js/JSAudioBufferSourceNodeCustom.cpp:42
>> +    imp->setBuffer(toAudioBuffer(value));
> 
> Do you guard against NULL inputs in AudioBufferSourceNode::setBuffer?

Yes

>> WebCore/bindings/js/JSConvolverNodeCustom.cpp:42
>> +    imp->setBuffer(toAudioBuffer(value));
> 
> Same question about ConvolverNode here.

Yes

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.