[Webkit-unassigned] [Bug 49974] Web Inspector: Request JSON-serialized heap profile.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 29 13:20:07 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=49974


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74788|review?                     |review+
               Flag|                            |




--- Comment #12 from Pavel Feldman <pfeldman at chromium.org>  2010-11-29 13:20:06 PST ---
(From update of attachment 74788)
View in context: https://bugs.webkit.org/attachment.cgi?id=74788&action=review

> WebCore/bindings/js/ScriptHeapSnapshot.h:43
> +        virtual ~OutputStream() {}

{ }

> WebCore/bindings/js/ScriptHeapSnapshot.h:53
> +    void writeJSON(OutputStream*) {}

{ }

> WebCore/inspector/front-end/HeapSnapshotView.js:73
> +    get _nameOrIndex()

We don't use getters for private fields.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list