[Webkit-unassigned] [Bug 25831] [GTK] events missing when a document is (re)loaded

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25831


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74398|0                           |1
        is obsolete|                            |
  Attachment #74398|review?                     |
               Flag|                            |
  Attachment #74920|                            |review?
               Flag|                            |




--- Comment #15 from Mario Sanchez Prada <msanchez at igalia.com>  2010-11-26 04:31:32 PST ---
Created an attachment (id=74920)
 --> (https://bugs.webkit.org/attachment.cgi?id=74920&action=review)
AtkDocument events implementation + New unit test

(In reply to comment #14)
> 
> My point is, either you know the test just has to finish, probably very fast, or not.
> If you don't, then there's something wrong and we should fix it, or make the test
> ASSERT in case it hits the problem. Otherwise we should be adding 10s timeouts
> everywhere just in case some test hangs... (FWIW the layout tests have this I
> believe, but it's done generally and not in each test separately).

After the discussion about this in the IRC, I just rewrote the unit test code in testatk.c not to use a new main loop nor a call to g_add_timeout(), using the g_test_trap_* API instead, where I set a 2secs timeout as guard for the unlikely case where the unit test would fail.

Attaching a new patch then

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.