[Webkit-unassigned] [Bug 50069] MathML: code cleaning needed in MathMLInlineContainerElement.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50069


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74859|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Daniel Bates <dbates at webkit.org>  2010-11-25 12:45:17 PST ---
(From update of attachment 74859)
View in context: https://bugs.webkit.org/attachment.cgi?id=74859&action=review

Thank you for cleaning this up. I have some minor nits.

> WebCore/ChangeLog:6
> +        Remove unnecessary namespace & style adjustments
> +        https://bugs.webkit.org/show_bug.cgi?id=50069

Disregarding the name/date, Reviewed by, and changed files lines, the formatting convention of a change log entry is bug title; bug URL; then bug description. And the bug description should be a full sentence.

So, the change log for this patch should have the form:

...
MathML: code cleaning needed in MathMLInlineContainerElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=50069

Remove unnecessary namespace & style adjustments.
...

See <http://webkit.org/coding/contributing.html#changelogs> as well as the referenced example <http://trac.webkit.org/changeset/43259>.

> WebCore/mathml/MathMLInlineContainerElement.cpp:82
>          return new (arena) RenderMathMLBlock(this);

Please un-indent this line of code so that it left-aligns with respect to the line "if (hasLocalName(mfencedTag))".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.