[Webkit-unassigned] [Bug 50083] [Gtk] ASSERT(d->m_response.isNull()) in contentSniffedCallback

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50083


Sergio Villar Senin <svillar at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74881|                            |review?
               Flag|                            |




--- Comment #1 from Sergio Villar Senin <svillar at igalia.com>  2010-11-25 08:14:19 PST ---
Created an attachment (id=74881)
 --> (https://bugs.webkit.org/attachment.cgi?id=74881&action=review)
Fix for the bug

This should be "the right thing". We should not emit the content-sniffed callback if it was disabled for that particular SoupMessage. The problem is that soup_message_disables_feature is not in the public API of SoupMessage.

My proposal would be to just apply the changes in ResourceHandleSoup.cpp (i.e. do not connect to the "content-sniffed" signal) because:
   * it's correct anyway
   * it'll fix the bug
   * the invalid signal emission is located in the soup imported code, and thus, when moved there the soup_message_disables_feature could be easily added then (we can add that code as a comment)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.