[Webkit-unassigned] [Bug 50024] [Qt][WK2] Support repeating timers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 25 07:15:01 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=50024





--- Comment #3 from Balazs Kelemen <kbalazs at webkit.org>  2010-11-25 07:15:01 PST ---
(In reply to comment #2)
> (From update of attachment 74760 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=74760&action=review
> 
> > WebKit2/Platform/qt/RunLoopQt.cpp:116
> > +    ASSERT(!repeatInterval || nextFireInterval == repeatInterval);
> 
> Hmm. This seems mysterious. Will nextFireInterval always == repeatInterval for repeat timers?
> If so, this function should be changed to take a "bool isSingleShot" instead of a second interval IMO.

Right. I would not like to touch the common part, but that was not the right
decision.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list