[Webkit-unassigned] [Bug 49999] better V8 bindings for HTML5 ImageData
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 25 04:10:45 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=49999
Vitaly Repeshko <vitalyr at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pfeldman at chromium.org
--- Comment #6 from Vitaly Repeshko <vitalyr at chromium.org> 2010-11-25 04:10:45 PST ---
Looks good. A few nits:
o After "Reviewed by" line in the change log add a short one-line summary: "[V8] Speed up data property access for ImageData."
o Update the rest of the change log description to emphasize the fact that pure JS properties are used.
o Comments in code should be formatted like sentences, starting with a capital letter.
o Typo: "elimnating" -> "eliminating".
After these are done you'll need a WebKit reviewer to set r+ (I can'd to this yet). Pavel (cc'ed) agreed to help.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list