[Webkit-unassigned] [Bug 50056] New: WebSocket: Workers threading issues related to String

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50056

           Summary: WebSocket: Workers threading issues related to String
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: yutak at chromium.org
                CC: ap at webkit.org, levin at chromium.org, ukai at chromium.org


I have found some (potential) errors from WebSocket's worker implementation.

* ThreadableWebSocketChannelClientWrapper (WebCore/websocket/ThreadableWebSocketChannelClientWrapper.h)
This class contains String (Vector<String> in fact) even though it is derived from ThreadSafeShared.
  - IIRC classes derived from ThreadSafeShared should not contain any String.

* WorkerThreadableWebSocketChannel::Bridge::send (WebCore/websocket/WorkerThreadableWebSocketChannel.{h,cpp})
A String is passed across threads with WorkerLoaderProxy::postTaskToLoader, but we don't call crossThreadString beforehand.

Maybe related to bug 48996.

David:
Could you check out the issues above and give some comments? I'm not very good at WebKit threading stuff. I would be happy to make actual fixes.

Thanks,

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.