[Webkit-unassigned] [Bug 45491] when empty, clicking "down" on outer-spin-button returns "max value"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45491





--- Comment #15 from Dai Mikurube <dmikurube at google.com>  2010-11-25 00:07:22 PST ---
(From update of attachment 74830)
View in context: https://bugs.webkit.org/attachment.cgi?id=74830&action=review

>> JavaScriptCore/ChangeLog:7
>> +
> 
> Write why we need this wtf/ change please.

Added a description.

>> JavaScriptCore/wtf/DateMath.h:89
>> +double calculateDSTOffset(double ms, double utcOffset);
> 
> The return values are unclear.  Milliseconds, seconds, minutes, or hours?

Milliseconds. Added.

>> LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js:28
>> +    else
> 
> If you follow WebKit C++ style in JavaScript code, we should add {}  for multiple-line if-clause / else-clause.

Done. Thanks!

>> WebCore/ChangeLog:7
>> +
> 
> Please write what behavior change we have.

Described.

>> WebCore/html/HTMLInputElement.h:270
>> +    virtual bool isRangeControl() const { return deprecatedInputType() == RANGE; }
> 
> Do not use deprecatedInputType() in new code.

Replaced with formControlType() == InputTypeNames::range().
Is it ok?

>> WebCore/html/InputType.h:92
>> +    virtual double defaultValue() const;
> 
> The name "defaultValue" is not good.  The functions of InputType are usually synchronized with HTMLInputElement, and HTMLInputElement already has defaultValue().

Replaced with startingValue().

>> WebCore/html/RangeInputType.cpp:165
>> +        element()->stepUpFromRenderer(stepMagnification);
> 
> Is this change related to this bug?

Yes, keydowns from renderer for range-type inputs are handled with stepUp(), not stepUpFromRenderer() without this change. It results in no clamping steps for range-type inputs.

If clamping steps (stepwise adjustment) is not related in this bug, this change should be done in another bug. We discussed it at https://bugs.webkit.org/show_bug.cgi?id=48976#c23

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.