[Webkit-unassigned] [Bug 25678] [GTK] Implement ROLE_COMBO_BOX

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25678


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cfleizach at apple.com




--- Comment #11 from Mario Sanchez Prada <msanchez at igalia.com>  2010-11-24 09:34:15 PST ---
(In reply to comment #9)
> [...]
> Program terminated with signal 11, Segmentation fault.
> #0  0x00002baaa52131e4 in WebCore::SelectElement::listBoxOnChange (data=..., element=0x1a8f5a0) at ../../WebCore/dom/SelectElement.cpp:180
> 180        ASSERT(!data.usesMenuList() || data.multiple());

It's kind of "funny" (not the best word, though) to realize that the patch itself is not causing the crash but something else triggered by the unit test (probably unrelated to the issue being fixed). Anyway, as Martin said to me, the crash was worth as it probably uncovered another issue, which I already have a theory for...

It looks like the problem is that this assertion because the combo box (dropdown list) being tested here is actually not compliant with such an statement:

    (gdb) p data.usesMenuList()
    $6 = true
    (gdb) p data.multiple()    
    $7 = false

This situation makes me think that perhaps what it's wrong here is the assertion itself, which might be wrong as it'd be proved by the fact that a combo box like this one actually "uses a menu list" while, at the same time, doesn't allow "multiple" selections.

But perhaps, I'm missing something, so before proposing getting rid of that assertion I'd like to hear other's opinions and/or suggestions, since that part of the code (HTML elements) it's pretty new for me, so I'm somehow wild guessing at this point.

Hence, adding Chris Fleizach to CC (and sorry Chris for adding you to a bug for the second time during today :P)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.