[Webkit-unassigned] [Bug 49927] [GTK] Windowless plugins gets broken key input event (at least in Flash)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49927


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74710|review?                     |review-
               Flag|                            |




--- Comment #12 from Martin Robinson <mrobinson at webkit.org>  2010-11-24 07:09:48 PST ---
(From update of attachment 74710)
View in context: https://bugs.webkit.org/attachment.cgi?id=74710&action=review

Just a couple nits.

> WebKitTools/DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:266
> +keycode_to_char(XKeyEvent *event)

I think this should be called keyEventToChar since it actually takes an XKeyEvent and not a keycode. Also, new code should follow WebKit style (event though the rest of the file doesn't).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.