[Webkit-unassigned] [Bug 49903] [GTK] Inspector: add a way to inspect a WebKitDOMNode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49903


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74539|review?                     |review-
               Flag|                            |




--- Comment #3 from Xan Lopez <xan.lopez at gmail.com>  2010-11-24 03:52:19 PST ---
(From update of attachment 74539)
View in context: https://bugs.webkit.org/attachment.cgi?id=74539&action=review

> WebKit/gtk/webkit/webkitwebinspector.cpp:504
> + * @web_inspector: the #WebKitWebInspector that will do the inspection

inspect_node would be better, I agree with Martin.

> WebKit/gtk/webkit/webkitwebinspector.h:26
>  #include <webkit/webkitdefines.h>

You shouldn't include the whole dom header just to use WebKitDOMNode*. Including webkitdomdefines.h should be enough, I think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.