[Webkit-unassigned] [Bug 49927] [GTK] Windowless plugins gets broken key input event (at least in Flash)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49927


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xan.lopez at gmail.com




--- Comment #3 from Xan Lopez <xan.lopez at gmail.com>  2010-11-23 15:38:16 PST ---
(In reply to comment #1)
> Created an attachment (id=74606)
 --> (https://bugs.webkit.org/attachment.cgi?id=74606&action=review) [details]
> Windowless plugins gets broken key input
> 
> When converting the GdkEvent to XEvent we need to send the
> hardware_keycode as XEvent::keycode. Instead we where sending
> the GdkEvent::keyval.

I think we might be missing something, because the original code was also sending bogus values and when we changed it to the current one we started to get correct results in the layout tests. At the very least we should have an explanation of why this is the right thing to do and a test for it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.