[Webkit-unassigned] [Bug 49498] focus issue with links that have tooltips

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 23 12:35:51 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=49498


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74531|review?, commit-queue?      |review+
               Flag|                            |




--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2010-11-23 12:35:51 PST ---
(From update of attachment 74531)
View in context: https://bugs.webkit.org/attachment.cgi?id=74531&action=review

Looks great. There is only one tiny thing that I'll change before landing.

> WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:526
> +    WebKitWebViewPrivate* priv = m_webView->priv;
> +    Node* node = hit.innerNonSharedNode();
> +    priv->tooltipArea = node ? node->getRect() : IntRect();

This should probably just be m_webView->priv->tooltipArea = ... I'll fix that and land it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list