[Webkit-unassigned] [Bug 49557] Add loadPlatformAudioResource() and decodeAudioFileData() to ChromiumBridge

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49557





--- Comment #14 from Chris Rogers <crogers at google.com>  2010-11-23 10:32:19 PST ---
(From update of attachment 73930)
View in context: https://bugs.webkit.org/attachment.cgi?id=73930&action=review

>> WebKit/chromium/public/WebAudioBus.h:46
>> +    ~WebAudioBus();
> 
> so any public method of a WebKit API class that is not inline needs to be decorated with WEBKIT_API.
> otherwise, it will break the Chromium multi-DLL build if Chromium code tries to call one of these
> methods.
> 
> now, stepping back... i don't think you actually intend for Chromium to call the destructor or the
> initialize method.  this suggests that they should be hidden from Chromium, so that Chromium cannot
> possibly call them.
> 
> since your goal is to pass data to Chromium in the scope of a decodeAudioFileData call, I suspect
> that you would be better served defining WebAudioBus as an interface, like WebVideoFrame.  then,
> in chromium/src/, just define a WebAudioBusImpl class that implements the interface and provides
> methods for initialization and releasing the contained AudioBus object.

Actually, the initialize() method is called from within Chromium.  This is how Chromium passes the decoded PCM audio data back to WebKit.
But, the destructor is not called in Chromium.

If you believe that adding the WEBKIT_API prefix to the destructor and initialize() method is not a good solution, then I'll have a look at the WebAudioBusImpl as you suggest.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.