[Webkit-unassigned] [Bug 49550] Fix android specific history bug

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49550





--- Comment #8 from Steve Block <steveblock at google.com>  2010-11-23 02:14:46 PST ---
(From update of attachment 74598)
View in context: https://bugs.webkit.org/attachment.cgi?id=74598&action=review

> WebCore/ChangeLog:5
> +        Use platform bridge to set scroll position.

You should update the bug title to match this updated description.

> WebCore/ChangeLog:9
> +        test introduced.

The patch no longer has anything to do with browsing history. In any case, LayoutTests are to test platform-independent functionality. This is a change to the Android implementation, so 'Refactoring only, tested by existing tests' suffices.

> WebCore/platform/android/PlatformBridge.h:109
> +    static void setScrollPosition(ScrollView*, int, int);

you should name the two int params, as it's not clear from their types what they are.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.