[Webkit-unassigned] [Bug 49125] [EFL] Add option to enable Touch Events.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49125





--- Comment #2 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-11-23 01:01:24 PST ---
(From update of attachment 74633)
View in context: https://bugs.webkit.org/attachment.cgi?id=74633&action=review

> WebCore/platform/efl/PlatformTouchEventEfl.cpp:36
> +namespace WebCore {
> +PlatformTouchEvent::PlatformTouchEvent(Eina_List* points, const IntPoint pos, TouchEventType type, int metaState)

Shouldn't there be some newline here?

> WebCore/platform/efl/PlatformTouchEventEfl.cpp:68
> +    // FIXME: We don't support metaState now.

'for now'

> WebKit/efl/WebCoreSupport/ChromeClientEfl.h:126
> +#if ENABLE(TOUCH_EVENTS)
> +    virtual void needTouchEvents(bool) { }
> +#endif
> +

What is that bool for?

> WebKit/efl/ewk/ewk_frame.cpp:1481
> +#if ENABLE(TOUCH_EVENTS)

I would add a newline before this one

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.