[Webkit-unassigned] [Bug 49946] [chromium] Implement Extensions3DChromium::getGraphicsResetStatusARB

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49946


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74610|review?                     |review-
               Flag|                            |




--- Comment #2 from Kenneth Russell <kbr at google.com>  2010-11-22 16:29:18 PST ---
(From update of attachment 74610)
View in context: https://bugs.webkit.org/attachment.cgi?id=74610&action=review

This basically looks good but there's one minor semantic bug.

> WebKit/chromium/src/Extensions3DChromium.cpp:53
> +    return m_internal->isContextLost() ? GraphicsContext3D::CONTEXT_LOST_WEBGL : GraphicsContext3D::NO_ERROR;

This should be returning one of NO_ERROR, GUILTY_CONTEXT_RESET_ARB, INNOCENT_CONTEXT_RESET_ARB, or UNKNOWN_CONTEXT_RESET_ARB. Since it sounds like we can't make the determination yet it should probably be UNKNOWN_CONTEXT_RESET_ARB.

> WebKit/chromium/src/WebGraphicsContext3DDefaultImpl.cpp:992
> +    return false;

Should we add a FIXME to implement this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.