[Webkit-unassigned] [Bug 33336] webkit-patch rollout should be able to do multi-revision rollouts
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 22 15:21:28 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=33336
--- Comment #3 from Adam Barth <abarth at webkit.org> 2010-11-22 15:21:28 PST ---
(From update of attachment 74544)
View in context: https://bugs.webkit.org/attachment.cgi?id=74544&action=review
We should have Eric look at this patch. He's on vacation at the moment, so that might take a week.
> WebKitTools/Scripts/webkitpy/common/checkout/scm.py:534
> + def apply_reverse_diff(self, revision_list):
> + for revision in revision_list:
> + # '-c -revision' applies the inverse diff of 'revision'
> + svn_merge_args = ['svn', 'merge', '--non-interactive', '-c', '-%s' % revision, self._repository_url()]
> + log("WARNING: svn merge has been known to take more than 10 minutes to complete. It is recommended you use git for rollouts.")
> + log("Running '%s'" % " ".join(svn_merge_args))
> + # FIXME: Should this use cwd=self.checkout_root?
> + self.run(svn_merge_args)
Have you tested this? The tricky part here is ChangeLogs. We might need to deal with the ChangeLog in each iteration of the loop.
> WebKitTools/Scripts/webkitpy/tool/commands/download.py:291
> - argument_names = "REVISION REASON"
> + argument_names = "REVISION(S) REASON"
This isn't usually how we document multiple arguments. Check out some of the other commands that take variable arguments for how we do that.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list