[Webkit-unassigned] [Bug 49924] [NRWT] Opening png sometimes fails on Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49924





--- Comment #4 from Hayato Ito <hayato at chromium.org>  2010-11-22 11:43:34 PST ---
Thank you for the review.
I addressed your comments.

(In reply to comment #2)
> (From update of attachment 74572 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=74572&action=review
> 
> > WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:464
> > +            except IOError:
> 
> Can we catch the exact IO error using errno?

Nice point. Done.

> 
> > WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:466
> > +                time.sleep(timeout_seconds / retry_num)
> > +                continue
> 
> I would probably try more frequently than every 500ms, maybe increase retry_num to 50?

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.