[Webkit-unassigned] [Bug 49382] Spatial Navigation: issues with the node selection algorithm.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 22 06:50:54 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=49382





--- Comment #43 from Yael <yael.aharon at nokia.com>  2010-11-22 06:50:53 PST ---
(In reply to comment #35)
> (From update of attachment 74412 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=74412&action=review
> 
> > WebCore/page/FocusController.cpp:606
> > +void updateFocusCandidateIfNeeded(FocusDirection direction, const IntRect& startingRect, FocusCandidate& candidate, FocusCandidate& closest)
> 
> As far as I can tell, this function does not modify candidate. Can we make this const?

I misinterpreted the compile error I received when I tried to add the const. candidate actually is being modified in this function, inside the call to distanceDataForNode. Sorry for not explaining it correctly in the first place.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list