[Webkit-unassigned] [Bug 49382] Spatial Navigation: issues with the node selection algorithm.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49382





--- Comment #41 from Yael <yael.aharon at nokia.com>  2010-11-22 05:28:25 PST ---
(In reply to comment #39)
Hi Antonio, thanks for reviewing (again :)

> (From update of attachment 74526 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=74526&action=review
> 
> > WebCore/ChangeLog:18
> > +        content of such a container. The only exception is if the container has style overflow:hidden. 
> > +        We will not scroll in that case.
> 
> It would be nice to have a test case for this case. I do not remember if you added it in the other bug.
> 
> > WebCore/ChangeLog:21
> > +        With this patch, we handle z-index and positioning so that if there are 2 overlapping focusable nodes,
> > +        we do a hit test and only the node on top can get focus.
> 
> Same here.
> 

The 2 tests that you are asking for were added in https://bugs.webkit.org/show_bug.cgi?id=49604. I will set the review flag for those tests after commiting the 2 patches from this bug.


> > WebCore/page/SpatialNavigation.cpp:543
> > +    if (!container->renderBox())
> 
> being a renderBox does not necessarily mean it is scrollable. Maybe
> 
> toRenderBox(container->renderer()) && toRenderBox(container->renderer())->canBeScrolledAndHasScrollableArea()
> 
> ?

I call canScrollInDirection() right bellow this line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.