[Webkit-unassigned] [Bug 49736] For speech input events, send an object containing all the recognition results and metadata.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49736


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74243|review?                     |review+
               Flag|                            |




--- Comment #4 from Jeremy Orlow <jorlow at chromium.org>  2010-11-22 03:24:28 PST ---
(From update of attachment 74243)
View in context: https://bugs.webkit.org/attachment.cgi?id=74243&action=review

r=me

> WebCore/page/SpeechInputEvent.h:42
> +    ~SpeechInputEvent() {}

Please put this and the constructor in a .cpp.  With something like a RefPtr of Vectors, this could lead to a lot of blow up in .o file size for anything that includes this file.

> WebCore/page/SpeechInputResultList.h:54
> +    SpeechInputResultList(const SpeechInputResultArray& results)

ditto (and for the ~)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.