[Webkit-unassigned] [Bug 49382] Spatial Navigation: issues with the node selection algorithm.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49382


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74526|review?                     |review+
               Flag|                            |




--- Comment #39 from Antonio Gomes <tonikitoo at webkit.org>  2010-11-21 21:24:46 PST ---
(From update of attachment 74526)
View in context: https://bugs.webkit.org/attachment.cgi?id=74526&action=review

> WebCore/ChangeLog:18
> +        content of such a container. The only exception is if the container has style overflow:hidden. 
> +        We will not scroll in that case.

It would be nice to have a test case for this case. I do not remember if you added it in the other bug.

> WebCore/ChangeLog:21
> +        With this patch, we handle z-index and positioning so that if there are 2 overlapping focusable nodes,
> +        we do a hit test and only the node on top can get focus.

Same here.

> WebCore/page/FocusController.cpp:679
> +bool FocusController::navigateInContainer(Node* container, const IntRect& startingRect, FocusDirection direction, KeyboardEvent* event)

advanceFocusDirectionallyInContainer?

> WebCore/page/FocusController.cpp:687
> +        newStartingRect = virtualStartingRectForDirection(direction, nodeRectInAbsoluteCoordinates(container));

Lets name it virtualRectForDirection.

> WebCore/page/SpatialNavigation.cpp:543
> +    if (!container->renderBox())

being a renderBox does not necessarily mean it is scrollable. Maybe

toRenderBox(container->renderer()) && toRenderBox(container->renderer())->canBeScrolledAndHasScrollableArea()

?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.