[Webkit-unassigned] [Bug 40302] [GTK] Memory managament for DOM GObject wrappers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40302


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74490|review?                     |review+
               Flag|                            |




--- Comment #14 from Martin Robinson <mrobinson at webkit.org>  2010-11-20 21:04:35 PST ---
(From update of attachment 74490)
View in context: https://bugs.webkit.org/attachment.cgi?id=74490&action=review

Very nice! This was tricky. Only change I think you should make (other than the two ultra nits below) is to use Frame* instead of void* for all things that deal with frames.

> WebCore/bindings/gobject/DOMObjectCache.cpp:103
> +        ASSERT(data->timesReturned == 0);

I think this has to be ASSERT(!data->timesReturned); to make the style gods happy.

> WebKit/gtk/webkit/webkithittestresult.cpp:81
> +    WebKitHitTestResultPrivate* priv = WEBKIT_HIT_TEST_RESULT(object)->priv;
> +
> +    g_object_unref(priv->innerNode);
> +
> +    G_OBJECT_CLASS(webkit_hit_test_result_parent_class)->dispose(object);
> +}

I think this should be two lines to preserve vertical space:

g_object_unref(WEBKIT_HIT_TEST_RESULT(object)->priv->innerNode);
G_OBJECT_CLASS(webkit_hit_test_result_parent_class)->dispose(object);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.