[Webkit-unassigned] [Bug 25831] [GTK] events missing when a document is (re)loaded

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25831





--- Comment #13 from Mario Sanchez Prada <msanchez at igalia.com>  2010-11-20 06:31:23 PST ---
(In reply to comment #12)
> (From update of attachment 74398 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=74398&action=review
> 
> > WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:196
> > +
> 
> Mmm, where is this used in the patch?

It's not explicitly used anywhere but this code allows that we get more complete information along with the signals issued by the webArea. 

In other words, without that code, we'd get things like this:

document:load-complete(0, 0, )
    source: [document frame | ]
    application: [application | GtkLauncher]


...but with the patch we'd get this:

document:load-complete(0, 0, Ubuntu Start Page)
    source: [document frame | Ubuntu Start Page]
    application: [application | GtkLauncher]

...as that information comes right from the atk_object_get_name() method executed over the AtkObject for the webArea object.

> > WebKit/gtk/tests/testatk.c:316
> > +    g_timeout_add(10000, (GSourceFunc)bailOutFromMainLoop, loop);
> 
> Uh, 10000? In general I don't like this thing of having a timeout "in case the test hangs". It should either pass or ASSERT somewhere IMHO. That being said, 10s is surely way too long.

Well, I don't really see the problem because the test would normally (actually all the times I tried it) run as quick as the reload process lasts (that is, way less than 10 secs, not even 1sec I'd say). The timeout is just a way to ensure the test won't hang, and I couldn't find any other better option for that.

Perhaps 10 secs is too much so we could lower that to 2-3 secs, that would look fine to me. But I do not see many other options here since we're dealing with asinchronous stuff... I'm open to suggestions, though :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.