[Webkit-unassigned] [Bug 49840] GraphicsContext: Make drawFocusRing() take a Path instead of a Vector<Path>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49840


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74440|review?                     |review-
               Flag|                            |




--- Comment #4 from Nikolas Zimmermann <zimmermann at kde.org>  2010-11-19 20:00:16 PST ---
(From update of attachment 74440)
View in context: https://bugs.webkit.org/attachment.cgi?id=74440&action=review

Almost there, I'm just wondering about the need of the offset parameter used in drawFocusRing/drawFocusRect.
The parameter offset is used in GraphicsContextMac.mm, drawFocusRect, but not in drawFocusRing, that causes your mac build problem.

In GraphicsContextQt the parameter is unused as well, do we need it? We have two options:
a) if we need it, and ignore it for now, add a FIXME and file a bug about it.
b) use the parameter, cover its usage by a test, if it doesn't affect existing tets.

> WebCore/platform/graphics/mac/GraphicsContextMac.mm:60
> +void GraphicsContext::drawFocusRing(const Path& path, int width, int offset, const Color& color)

offset is unused causing the mac build error.

> WebCore/platform/graphics/mac/GraphicsContextMac.mm:-66
> -    offset += radius;

It built before, as offset was touched here, even if the code below doesn't use it.

> WebCore/rendering/RenderImage.cpp:361
> +        paintInfo.context->drawFocusRing(areaElement->getPath(this), style->outlineWidth(), style->outlineOffset(), style->visitedDependentColor(CSSPropertyOutlineColor));

Hm, the style->outlineOffset() parameter is passed to drawFocusRing. For example in GraphicsContextCG it remains unused, that's why your mac build failed according to EWS.
In GraphicsContextQt is's also unused. Can you identify whether we need this parameter? I guess we do, and current implementations just don't respect them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.