[Webkit-unassigned] [Bug 49812] [NRWT] Simplify Driver.run_test() so that it takes only one parameter, TestInput.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49812





--- Comment #5 from Hayato Ito <hayato at chromium.org>  2010-11-19 15:43:23 PST ---
Thank you for the review, Dirk.
I'll address your comments and will land the updated patch later. Thank you.

(In reply to comment #3)
> (From update of attachment 74403 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=74403&action=review
> 
> Patch looks good to me . There are a couple of minor nits below.
> 
> > WebKitTools/Scripts/webkitpy/layout_tests/driver_test.py:45
> >      image_path = 'image_result.png'
> 
> Please just delete this file; even I don't really have a use for it any more. Originally I intended it to be a way for people to test their port Driver implementations w/o needing the rest of the NRWT scaffolding, but I don't think it's that useful at this point.
> 
> > WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:106
> > +        # checksums match. The image_hash is set lazily to reduce startup time.
> 
> Please change the second sentence to something like "The image hash is set later, and only if it is needed for the test". I want to remove the "lazy" part of this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.