[Webkit-unassigned] [Bug 48809] Update correct content state during back/forward navigations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 19 15:27:33 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=48809





--- Comment #43 from Charles Reis <creis at chromium.org>  2010-11-19 15:27:32 PST ---
(In reply to comment #42)
> Rolled out in http://trac.webkit.org/changeset/72334
> 
> Broke chromium ui test SessionHistoryTest.FrameBackForward.

Good news-- that test caught a real issue with the patch, and it uncovered a previously existing bug that we can now fix.  (We weren't saving form state for subframes when you navigate back and forward.)

Turns out there was one other place in HistoryController where we were changing m_currentItem but not m_previousItem (in recursiveGoToItem).  Before my patch, that caused us to skip the content state update in that case, which meant we didn't save form state if the form was in a subframe and you navigated back/forward.

After my earlier patch landed, we were updating the wrong history item, which was caught by Chrome's UI test.  I've now fixed recursiveGoToItem so that it updates m_previousItem, and I've added a layout test for it in the latest patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list